Update GopherJS Playground JS.

gopherjs / gopherjs.github.io

GopherJS Playground

https://gopherjs.github.io/playground/

23 stars 12 forks source link

Update GopherJS Playground JS. #12

Closed dmitshur closed 9 years ago

dmitshur commented 9 years ago

Use currently latest gopherjs/gopherjs@a06da553517182567caa3d61e95a1a9175bcc745.
Fix update.sh to use "_min" instead of "-min" suffix, due to change in gopherjs/gopherjs@8a07f255aaef61e9b8aa09a1d9d93640372b59ef.

This is my first time doing the update.sh process for playground. Please review.

This is needed for #11 and #6. I will rebase that PR on top of this.

dmitshur commented 9 years ago

From testing the results of this PR locally, it seems to work fine to me. (A few simple) programs execute and no errors in JS console.

Also, if an issue is uncovered, reverting this PR is quick and easy.

dmitshur commented 9 years ago

Ok, I'm going to exercise my judgement here to merge this now. I think it should be fine (low risk); if not we can undo (right away or within a few days). Also, for this kind of change (updating generated code to new version), it's easier to verify that nothing went wrong after doing it...

If I end up doing something wrong, I can learn from my mistake and I'm taking responsibility for it. :)

dmitshur commented 9 years ago

As expected, http://gopherjs.org/play/ seems to be working equally fine. Let me know if there any issues.