gopherjs / gopherjs.github.io

GopherJS Playground
https://gopherjs.github.io/playground/
23 stars 12 forks source link

_config.yml: Don't explicitly specify markdown engine. #50

Closed dmitshur closed 8 years ago

dmitshur commented 8 years ago

Fixes #49.

This is not tested. Done based on what the email said in https://github.com/gopherjs/gopherjs.github.io/pull/48#issuecomment-187121291, to remove specifying markdown option in the _config.yml.

I don't think we're using any subtle features, so the default markdown engine, whatever it may be, should be okay.

neelance commented 8 years ago

Yeah. I'm okay with merging and then checking the output.

dmitshur commented 8 years ago

Let's try. Will revert if I spot any issues.

dmitshur commented 8 years ago

I see some minor differences, but no major issues.

Before:

image

After:

image

The largest minor issue is that code blocks have a strange 0-width left padding.

image

dmitshur commented 8 years ago

On the plus side, no more warning email!

dmitshur commented 8 years ago

FWIW, the HTML before:

image

And after:

image

neelance commented 8 years ago

Seems like the CSS file needs an update.