search

gopherjs / gopherwasm

This package is deprecated. Use syscall/js of GopherJS instead.
BSD 2-Clause "Simplified" License
79 stars 5 forks source link

Remove "fmt" dependency in js_notwasm.go #4

Closed elliott5 closed 6 years ago

elliott5 commented 6 years ago

Reduces the generated JS for a small project by around 1Mb

hajimehoshi commented 6 years ago

Oh, you created this PR for api branch? master branch was also fine in this case.

hajimehoshi commented 6 years ago

@elliott5 I plan to squash all the commits in #3, so your commit would be integrated in it. It's ok if you are ok, but if you want to keep the commit in this Git repository, I'd recommend to create the same PR for master branch instead of api branch before merging #3.

elliott5 commented 6 years ago

It's OK @hajimehoshi I've no desire to be famous ... squash away!