search

gopherjs / websocket

websocket provides high- and low-level bindings for the browser's WebSocket API.
BSD 3-Clause "New" or "Revised" License
111 stars 25 forks source link

websocket.Conn should fulfill net.Conn #6

Closed mjohnson9 closed 9 years ago

mjohnson9 commented 9 years ago

Now that gopherjs/gopherjs#123 is fixed, I've made a couple of simple changes to make websocket.Conn fulfill the net.Conn interface. Looking for a code review.

As websocket.Addr doesn't need to be exported anymore, I felt that it added clutter to the docs. As such, I've unexported it.

dmitshur commented 9 years ago

LGTM.

As websocket.Addr doesn't need to be exported anymore, I felt that it added clutter to the docs. As such, I've unexported it.

:+1: The fewer things that are exported, the better.

mjohnson9 commented 9 years ago

Merging and deleting the feature branch.