gophish / api-client-python

A Python API Client for Gophish
MIT License
44 stars 48 forks source link

SMTP Documentation is Wrong #9

Closed ethack closed 6 years ago

ethack commented 6 years ago

The model attributes for SMTP profiles has the wrong documentation. This page has a list that I think is for Email Templates instead of SMTP profiles.

    id (int) The smtp ID
    name (str) The smtp name
    html (str) The smtp HTML
    text (str) The smtp HTML
    modified_date (optional: datetime.datetime) The scheduled time for smtp launch
    attachments (list(models.Attachment)) The optional email attachments

I think the real list should be based on these lines. I'd be happy to update and submit a pull request, but I'm not sure where/if that's possible with Gitbook.

jordan-wright commented 6 years ago

Thanks for reporting this! I eventually need to find some time to sit down and work on the Python client and associated documentation to do some cleanup.

For now, I've gone ahead and synced the Gitbook content to Github, so pull requests should be possible 😄

I've also fixed this particular documentation issue. Thanks again for reporting it!