search

gophish / gophish

Open-Source Phishing Toolkit
https://getgophish.com
Other
11.29k stars 2.19k forks source link

gophish is crashing on html template #423

Open drewbeebe opened 7 years ago

drewbeebe commented 7 years ago

I see in crash message below that there's a bad character. Which HTML template is it referring to? HTML template for the landing page? Or the HTML template for the email? (I'm using HTML in my email, as well).

2016/11/09 15:20:07 worker.go:90: template: html_template:12: unexpected bad character U+003C '<' in command panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal 0xb code=0x1 addr=0x10 pc=0x61a4a5]

jordan-wright commented 7 years ago

Are you building from source or using a pre-built binary? When is the error occurring - is it when sending the emails, or is it when someone hits the landing page?

jordan-wright commented 7 years ago

Hey @drewbeebe, just wanted to check in on this. Are you building gophish from source, or using a pre-built binary?

drewbeebe commented 7 years ago

Sorry. It is a prebuilt binary and, while I fixed it my simplifying the HTML, it should be noted that complex HTML pasted in might be giving gophish some problems in the email field.

-Drew

On Nov 21, 2016, at 12:16 AM, Jordan Wright notifications@github.com wrote:

Hey @drewbeebe, just wanted to check in on this. Are you building gophish from source, or using a pre-built binary?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jordan-wright commented 7 years ago

Yeah, it looks like this is the result of "smart pasting", as opposed to pasting as plaintext. I'll see if there are CKEditor options to fix this for HTML tag characters (<>/).