search

gopilla / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

SUMMARY #1

Open gdedi001 opened 7 years ago

gdedi001 commented 7 years ago

Grade: Satisfactory

Fantastic job on your project - you met all the design requirements to a tee! Your code is very well organized and its evident that you put quite a bit of work on this project. In addition to this, the mobile view, and overall color scheme of your site looks great! The only area for improvement here is with your usage of the class attribute. In many instances you should have opted for the id attribute instead.

A recommendation here is to read the following article on the differences between class and id and Implement these changes to your project. Now its up to you to figure out what you want to do with your new skills! If you want to dive deeper into web development with respect to web applications, I highly recommend making the investment and learning about JavaScript! Luckily you can take some free courses at Codecademy to get a feel for it! Congrats on your project! 👍

gopilla commented 7 years ago

Thank you very much for your critical and helpful review. Indeed, it was a lot of effort, sometimes I had to clean the slate completely with some parts to make it happen. But this is also a new skill I learned here: never to give up, just wait and you will figure out. I am so happy you liked the color scheme too:) Thanks for the tips on class and id but where is the article you suggest? Now my plan is to learn live in a bootcamp, the program I choose is mainly focussed on Ruby. Any suggestions on what is more useful these days to learn JS or RubyonRails? All the best to you:) Gabriella

gdedi001 commented 7 years ago

Without a doubt, JavaScript. Technologies like nodejs allow you to do away with learning RoR and create server side code all in JS!

gdedi001 commented 7 years ago

Also, here's the link I meant to send! https://css-tricks.com/the-difference-between-id-and-class/