goplus / builder

Go+ Builder
https://builder.goplus.org
19 stars 18 forks source link

refactor: sound editor & recorder #607

Closed ComfyFluffy closed 1 week ago

qiniu-x[bot] commented 1 week ago

[Git-flow] Hi @ComfyFluffy, There are some suggestions for your information:


Rebase suggestions

  • Following commits have duplicated messages

refactor:

refactor:

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here: - **https://github.com/qiniu/reviewbot**
ComfyFluffy commented 1 week ago

几个 WaveformXxx 组件(以及 sum-processor.js)考虑用单独的目录(比如 Waveform)进行组织?另外可以通过 index.ts 控制下哪些文件预期对外暴露,哪些不暴露

以及 wavesurfer.js 应该可以干掉了?

Done

qiniu-ci commented 1 week ago

The PR environment is ready, please check the PR environment

[Attention]: This environment will be automatically cleaned up after a certain period of time., please make sure to test it in time. If you have any questions, please contact the builder team.