search

goplus / community

Go+ Community written in Go+
Apache License 2.0
11 stars 15 forks source link

fix:video cache use lru #279

Closed huangsihao7 closed 6 months ago

huangsihao7 commented 6 months ago

Issue: refactor local task cache to LRU implement，adding a lock to isActive solves concurrency problems Reference methods: Reference: https://github.com/hashicorp/golang-lru

qiniu-prow[bot] commented 6 months ago

@huangsihao7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
community-pull-preview-environment-test dabdb3bbaf66839053a695aed7f7a750b3c690ba link true /test community-pull-preview-environment-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
qiniu-x[bot] commented 6 months ago

[Git-flow] Hi @huangsihao7, There are some suggestions for your information:

Rebase suggestions

  • Following commits seems generated via git merge

Merge branch 'goplus:dev' into dev

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here: - **https://github.com/qiniu/reviewbot**
qiniu-prow[bot] commented 6 months ago

@huangsihao7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
community-pull-preview-environment-test 5609a5747c1df2ef3b160116fe5cfa8e190982c7 link true /test community-pull-preview-environment-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).