search

goplus / gop

The Go+ programming language is designed for engineering, STEM education, and data science. Our vision is to enable everyone to become a builder of the digital world.
https://goplus.org
Apache License 2.0
8.92k stars 546 forks source link

Remove filesystem abstraction #365

Closed wangkuiyi closed 4 years ago

wangkuiyi commented 4 years ago

In parse.go there is an abstraction of filesystems:

https://github.com/qiniu/goplus/blob/251e782877a2b357b7cba48dc00fe398d8600ab7/parser/parse.go#L35-L56

I am not sure if we really want this. It looks to me that if the source files are not on the local filesystem, it is the responsibility of FUSE or other filesystem abstraction mechanisms to "mount" them to the local filesystem so that application developers shouldn't need to care about this.

If this is correct, how about we remove this abstraction?

xushiwei commented 4 years ago

This is used by our testcases. We use github.com/qiniu/goplus/ast/asttest.NewSingleFileFS to test.