Allow connections to password-less WiFi networks

gopro / OpenGoPro

An open source interface specification to communicate with a GoPro camera with accompanying demos and tutorials.

https://gopro.github.io/OpenGoPro/

MIT License

677 stars 149 forks source link

Allow connections to password-less WiFi networks #317

Open petrpavlik opened 1 year ago

petrpavlik commented 1 year ago

The BLE protobuf specs state that pasword field for RequestConnectNew is required https://github.com/gopro/OpenGoPro/blob/main/protobuf/network_management.proto.

What we've tried to do is check the flags of returned ScanEntry and if SCAN_FLAG_AUTHENTICATED is not present, we try to call RequestConnectNew with an empty password (empty string). The result seems to be PROVISIONING_ERROR_PASSWORD_AUTH error.

Is connected a GoPro to a wifi that's not password-protected supported?

tcamise-gpsw commented 9 months ago

Interestingly the answer is currently no. But this certain seems like a valid use case.

tcamise-gpsw commented 4 months ago

After discussing internally this is the currently expected behavior. I'll leave this open but change to enhancement.