search

gopro / OpenGoPro

An open source interface specification to communicate with a GoPro camera with accompanying demos and tutorials.
https://gopro.github.io/OpenGoPro/
MIT License
708 stars 152 forks source link

GetHardwareInfo HTTP Spec Response Mismatch #581

Closed mijoost closed 1 month ago

mijoost commented 2 months ago

According to the API documentation (both, website and OpenAPI spec) /gopro/camera/info should return an info object. However, with firmware H23.01.02.20.00 that info object level is omitted (items appear at top level).

curl --request GET --url "http://${CAMERAIPADDRESS}:8080/gopro/camera/info"

{
    "model_number": "62",
    "model_name": "HERO12 Black",
    "firmware_version": "H23.01.02.20.00",
    "serial_number": "C3501xxxxxxxxx",
    "ap_mac_addr": "xxxxxxxxxxxx",
    "ap_ssid": "GP25xxxxxx"
}
tcamise-gpsw commented 2 months ago

Good catch. I'll update the docs.

tcamise-gpsw commented 1 month ago

This has been fixed in the spec