search

gor181 / react-notification-system-redux

Redux wrapper for react-notification-system
MIT License
324 stars 59 forks source link

Error with version 1.1.5 #48

Closed aurbano closed 7 years ago

aurbano commented 7 years ago

I think there's an issue with version 1.1.5, seems related to this comment on another issue.

TypeError: _reactNotificationSystemRedux2.default.success is not a function
mutsumiya commented 7 years ago

I got the same error but for success and error. And then fixed by changing from:

import Notifications from 'react-notification-system-redux'

to

import * as Notifications from 'react-notification-system-redux'
danielgary commented 7 years ago

Any chance you can unpublish this version or fix this issue in a new release? This is a breaking change. Either fix in a patch or unpublish and publish this release as a major version change?

We have a common library that depends on this and it took me an hour to track down where things went wrong.

gor181 commented 7 years ago

Published a 1.1.6 with fix to this issue. Should be fine.. apologies for the inconvenience..

aurbano commented 7 years ago

All working well, thanks!