gor181 / react-notification-system-redux

Redux wrapper for react-notification-system
MIT License
324 stars 59 forks source link

Update peerDependencies in package.json #53

Closed ahaider48 closed 7 years ago

ahaider48 commented 7 years ago

Upon updating to React 16, and running yarn check I get the following errors:

error "react-notification-system-redux#react@^0.14 || ^15.0.0-rc || ^15.0" doesn't satisfy found match of "react@16.0.0"
error "react-notification-system-redux#react-dom@^0.14 || ^15.0.0-rc || ^15.0" doesn't satisfy found match of "react-dom@16.0.0"

It would be nice if you can include react and react-dom 16 in your package.json peerDependencies as well if possible.

ahaider48 commented 7 years ago

This issue has been fixed in https://github.com/gor181/react-notification-system-redux/pull/51

gor181 commented 7 years ago

Updated the PR #51 as tests are failing