search

gor181 / react-notification-system-redux

Redux wrapper for react-notification-system
MIT License
324 stars 59 forks source link

react-notification-system as a peer dependency #54

Open ahaider48 opened 7 years ago

ahaider48 commented 7 years ago

Currently, your installation instructions says to install both react-notification-system and react-notification-system-redux. However, you included react-notification-system as a dependency in your package.json as well. Is there a reason for that?

shouldn't it be moved to peerDependencies section instead?

gor181 commented 7 years ago

If it ain't a dependency you won't be able to run examples locally or run tests? afaik. Let me know if you managed to get it working as peer dependency in those cases. Most likely we could move it to dev-dependencies.

Oskku commented 2 years ago

Can you please add react 17 and 18 to it ?