search

goraft / raft

UNMAINTAINED: A Go implementation of the Raft distributed consensus protocol.
MIT License
2.43k stars 480 forks source link

Fix data race #205

Closed xiang90 closed 10 years ago

xiang90 commented 10 years ago

Fix all data race in raft.

https://drone.io/github.com/xiangli-cmu/raft/27

xiang90 commented 10 years ago

/cc @unihorn @philips

benbjohnson commented 10 years ago

@xiangli-cmu Where are you seeing the data races? From go test -race? Or from -race on etcd?

xiang90 commented 10 years ago

@benbjohnson go test -race. I will test it against etcd and fix the race found there in another pull request.

xiang90 commented 10 years ago

@unihorn Can you test this changes on etcd? Thanks.

yichengq commented 10 years ago

These changes look good to me. @xiangli-cmu I have tried to bump it into etcd, and it works well.

philips commented 10 years ago

lgtm, merge at will.