search

goranbrostrom / eha

eha
6 stars 1 forks source link

Makeham documentation inconsistent with code #17

Closed osorochynskyi closed 3 months ago

osorochynskyi commented 4 months ago

Hello, thank you for this package.

I believe the order of the shape parameters is reversed. The help page for Gompertz-Makeham distribution states that the hazard function is defined as $h(x) = shape[1] + shape[2] \exp(x/scale)$ whereas throughout the code it is shape[2] + shape[1] \exp(x/scale).

Given that existing code may depend on this behavior, I believe it will be better to update the documentation rather than the code.

Best regards, Oleksandr

osorochynskyi commented 3 months ago

Issue corrected in 754ce45d878ab17e374b7617260c58bc4b46e1ad Thank you !