search

gorangajic / react-icon-base

base icon for https://github.com/gorangajic/react-icons
51 stars 24 forks source link

Default color for icon that specified in component styles has bigger priority than CSS class color #10

Closed aodinok closed 8 years ago

aodinok commented 8 years ago

In our project we are using CssModules and react-icons. We specifying colors/size and other possible properties thru CSS styles by assigning styleName to icon, which is converted by CssModules to className. With last changes all icons in our project has one color that specified as default for BaseIcon component. The problem is that this default color has bigger priority than color that we specify by setting CSS class name for icon. Guys do you agree that color is better to hold in CSS styles than in React component props? 3b86c0ce-4437-11e6-840e-631f970d0932

bentatum commented 8 years ago

this should be fixed as of v2.0.3