search

gorastudio-git / SCNRecorder

The best way to record your AR experience!
MIT License
201 stars 51 forks source link

SceneView can freeze when invoking sceneView.startVideoRecording() #22

Closed miketabb33 closed 3 years ago

miketabb33 commented 3 years ago

Just want to start by saying I think this library is really great, especially when compared to the few other sceneView recorders libraries. This library produces such a light weight and smooth recording experience.

But, Every so often, the scene view will freeze when invoking the sceneView.startVideoRecording() function, causing other areas of the UI to become unresponsive resulting in a force quit by the user. I tested on iPhone 8+, 4 out 25 AR record sessions experienced this freezing issue.

Is this a know issue? Has anybody else experienced library behavior as described above?

v-grigoriev commented 3 years ago

Hi @miketabb33, two questions for now. Are you using the newest version i.e. 2.4.0? and do you call sceneView.prepareForRecording() at viewDidLoad()?

I faced this issue when AWAssetWriter blocked the main thread for a long time on a first run. I added a workaround for this a few versions ago.

Otherwise, it would be great if you run instruments, profile your app and find what is so time-consuming :)

miketabb33 commented 3 years ago

Hi @v-grigoriev, The current version specified in the pod file is pod 'SCNRecorder', '~> 2.4' Confirmed, the sceneView.prepareForRecording() is called at viewDidLoad()

I profiled the app on a iPhone 7 and an iPhone SE (2g) and observed some leaks in CoreVideo. I A/B tested with another sceneView recording library and didn't find any leaks which makes me think the leaks are related to the library. Im also running instruments on a 2013 macBook pro, Im not sure if that could have anything to do with it lol. Also, not sure how related this could be in regards to my original issue report. I just want to share what I see :) I added some screen shots below for additional context. The screenshot with the completed responsible library and frame are from the iPhone 7.

Not sure how to how to read process times but my app is on the heavier side which may be a factor in freeze up. :) Thanks for the quick reply!!

Screen Shot 2021-02-05 at 10 03 06 AM Screen Shot 2021-02-05 at 10 03 06 AM
v-grigoriev commented 3 years ago

So far I can't even reproduce the issue with the example app. I tried with SE (1g) and 12. Is the issue reproducible with the example app? If not, can you compare what is the difference in our sceneView usage?

v-grigoriev commented 3 years ago

@miketabb33 This should be fixed in 2.5.0. Can you please verify?