search

gorastudio-git / SCNRecorder

The best way to record your AR experience!
MIT License
201 stars 51 forks source link

Add Swift Package Manager support #27

Closed pixelier closed 3 years ago

v-grigoriev commented 3 years ago

Hi @ramiallam, feel free to send PR.

Reality-Dev commented 3 years ago

Hi @ramiallam, feel free to send PR.

I tried making a fork in an effort to make a PR to support Swift Package Manager, but Swift Package Manager apparently does not support multiple languages in one package, and there is at least one Objective-C file in this package. Please fix the code so it can work with SPM, it is much easier to use.

v-grigoriev commented 3 years ago

This is exactly why it wasn’t added initially. The objective-c file is used for a reason as the most convenient way to implement multicast delegate. Probably it can be split to a different package.

Vladislav Grigoryev

On 21 Jul 2021, at 6:09 AM, Grant Jarvis @.***> wrote:

 Hi @ramiallam, feel free to send PR.

I tried making a fork in an effort to make a PR to support Swift Package Manager, but Swift Package Manager apparently does not support multiple languages in one package, and there is at least one Objective-C file in this package. Please fix the code so it can work with SPM, it is much easier to use.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

v-grigoriev commented 3 years ago

I moved the multicast delegate to a separate repository and added it as a dependency. SPM support is added. I hope I haven't missed something. Fell free to test and open an issue if something is broken.

Reality-Dev commented 2 years ago

Hi @v-grigoriev ! Thank you for working on this. Unfortunately when I try to add this as a swift package it does not work. In Xcode 13.0 I go to file > Add packages and then I paste in the URL of this repository https://github.com/gorastudio/SCNRecorder and it tells me "The remote repository could not be accessed".