search

gorastudio-git / SCNRecorder

The best way to record your AR experience!
MIT License
201 stars 51 forks source link

Fix wrong color profile on some devices. Add note on how to fix NSCameraUsageDescription requirement. #44

Closed giomurru closed 2 years ago

giomurru commented 2 years ago

This should solve the issue of wrong colors when recording on some devices. It also includes instructions on how to solve the problem of appstoreconnect requiring NSCameraUsageDescription key.

v-grigoriev commented 2 years ago

Hi @giomurru, thank you for your involvement. Unfortunately this change breaks color on other devices and/or iOS versions. videoColorProperties were set for a purpose and can't be simply dropped.

You can check this by running the Example app with your changes, choosing Metal Example and recording Video (I checked with iPhone 12 and iOS 15.5).

It will be also reproducible on lower iOS versions where wide color is used for ARKit/SceneKit by default.

giomurru commented 2 years ago

Ok, I am sorry. I can now notice the small shift in colors caused by this modification. I was trying to find a way to correct the issue #45