search

gordlea / fireboard2mqtt

8 stars 5 forks source link

fix: fixes erroneous json errors in home assistant core log #52

Closed gordlea closed 5 months ago

gordlea commented 5 months ago

Fixes #51

@mattdevo1 This PR should fix the issue, it was actually not too hard to find, I was setting a blank string for state when a channel or the drive was offline, as that deletes the entry in mqtt, but home assistant doesn't appreciate it.

Instead, now I'm trying out the expires_after property. I will do a release later today.

mattdevo1 commented 5 months ago

You're a legend, thank you! I will test later today when you push the new release. Thanks!

P.s. at this point, do you think it makes sense to drop the debug logging default config setting? The add-on has been pretty solid for a while now.

gordlea commented 5 months ago

Yes, good idea, I'll change that also.

mattdevo1 commented 5 months ago

3.1.3 seems to have fixed the JSON errors for me, thank you @gordlea

I haven't fully tested everything, but I'll let you know if I see an issue.