gordon-cs / JES4py

Other
7 stars 3 forks source link

Modify show function to work on windows system #85

Closed johntsweeney closed 1 year ago

johntsweeney commented 1 year ago

When creating its wx.Bitmap object, the explore() implementation only passes in the wx.Image object, whereas the show() implementation passes in both the wx.Image object along with a constant wx.BITMAP_TYPE_ANY. Instead of passing in this constant during instantiation of its bitmap object, explore() passes this constant into the creation of its image object. This change simply removes that constant from the bitmap object creation in the show() file. Some tests across Linux, Mac, Win10, and Win11 suggest that this change offers no additional drawbacks on the systems which already worked with the show function (Mac and Linux), and it does offers sufficient functionality for students using Windows computers to complete the baseline Forest Fire Simulation project.

jsenning commented 1 year ago

This problem has existed for more than a year and it's good to have a fix for it -- particularly one that was so straightforward!