gordon-cs / Project-Phoenix

The Electronic Room Condition Inventory
0 stars 0 forks source link

changing datetime format #165

Closed fallcat closed 7 years ago

eanyanwu commented 7 years ago

What was the problem with the signature page before?

fallcat commented 7 years ago

The RA would not be able to enter signature as RA for his/her individual RCI

fallcat commented 7 years ago

Actually, for a Common Area RCI, if the AC is the last one to sign, the page will still redirect back to dashboard after they sign as resident, and they have to go back to sign as AC.. which is not very smooth. I'm still thinking to change that.

eanyanwu commented 7 years ago

I'm not sure what the problem is. I just reset my RCI then signed it fine:

capture d ecran 2017-05-07 a 19 23 49

For the common area signature thing, that's a good point. If you want to change it, could you do it in a new branch though?

fallcat commented 7 years ago

I've already fixed the problem for individual RCI. Are you testing from my branch or the original one?

eanyanwu commented 7 years ago

The original one, master

fallcat commented 7 years ago

virtualbox_windows10_07_05_2017_19_32_49 But you are only able to sign as resident to confirm the damages, and sign the life and conduct statement. You can't sign as RA to confirm the damages.

eanyanwu commented 7 years ago

If you are an RA, that signature updates for both the CheckinSigRes and CheckinSigRA columns. So you don't need to sign three times. If you are a resident, it just just updates the CheckinSigRes column.

fallcat commented 7 years ago

Alright

fallcat commented 7 years ago

That does make sense. I'll change it back.

fallcat commented 7 years ago

fixed

eanyanwu commented 7 years ago

Yikes, I messed up on GitHub comments. Ignore the previous attempts

Sweeet! Two last things though:

When the person has already signed, you should probably remove the name attribute of the input field. If not, the signature will get resubmitted. Don't forget to add the Life and conduct statement for the RA as well!

eanyanwu commented 7 years ago

Jk my issues were addressed. Looks great to me!