gordon-cs / gordon-360-api

The 360° Gordon Experience
12 stars 7 forks source link

Post summer updates #1000

Closed EjPlatzer closed 1 year ago

EjPlatzer commented 1 year ago

I have made some minor updates to improve upon the great work done this summer by the practicum team.

I cleaned up StateYourBusiness slightly by removing unused references and replacing strings with Enums.

I restored a streamlined and easier to understand logic flow for enforcing privacy on the GetMemberships method (this was going to be changed but the change was abandoned, however in undoing the change, we ended up over complicating the logic).

Finally, I significantly improved the performance of the UserCourses view in the database, and refactored the code that calls it for simplicity and clarity. There are no breaking changes to the UI from this refactoring.