I have updated our files to use file-scoped namespaces. This reduces the indentation of basically all our code by one level, making the code easier to read and understand.
Obviously this is a massive change in terms of affected lines (and GitHub's diffing algorithm doesn't make it easy to understand) but I think it's still worthwhile because it makes our code easier to understand. The only reason you wouldn't a file-scoped namespace is if you were going to have multiple namespaces in one file. Given that that is considered bad practice and we don't do it at all as far as I'm aware, I see this as an absolute win for our codebase.
I also ran the code cleanup configuration tool which applies our editor config formatting settings to the codebase. This seems to have mostly affected bad whitespace (i.e. missing commas) as well as alphabetizing using statements.
EjPlatzer
commented
9 months ago
I have updated our files to use file-scoped namespaces. This reduces the indentation of basically all our code by one level, making the code easier to read and understand.
Obviously this is a massive change in terms of affected lines (and GitHub's diffing algorithm doesn't make it easy to understand) but I think it's still worthwhile because it makes our code easier to understand. The only reason you wouldn't a file-scoped namespace is if you were going to have multiple namespaces in one file. Given that that is considered bad practice and we don't do it at all as far as I'm aware, I see this as an absolute win for our codebase.
I also ran the code cleanup configuration tool which applies our editor config formatting settings to the codebase. This seems to have mostly affected bad whitespace (i.e. missing commas) as well as alphabetizing using statements.