gordon-cs / gordon-360-api

The 360° Gordon Experience
11 stars 6 forks source link

Upgrade to .NET 8 #1010

Closed EjPlatzer closed 10 months ago

EjPlatzer commented 10 months ago

This Pull Request updates the API to use .NET 8 (the new Long-term Support version as of November 14, 2023). This version of .NET will be supported until 2026, and has MANY performance improvements (especially including the ones from .NET 7 as well).

While there are new features we can take advantage of by updating, they are not mandatory. After performing the upgrade with the .NET Upgrade Assistant (and testing it locally), there appear to be no breaking changes that affect our application.

bennettforkner commented 10 months ago

Have you tested this upgrade extensively? I would be surprised if nothing broke because of the version jump.

EjPlatzer commented 10 months ago

Have you tested this upgrade extensively? I would be surprised if nothing broke because of the version jump.

Yes, I tested the full application interactively and tested operations on most pages.

Also, there is no reason to suspect that anything broke. The upgrade is largely backwards compatible with only a few, extremely targeted and rare to encounter, breaking changes. The full lists are here:

I have reviewed each breaking change and none apply to our application.