gordon-cs / gordon-360-api

The 360° Gordon Experience
11 stars 6 forks source link

Use File-Scoped Namespaces #1016

Closed EjPlatzer closed 7 months ago

EjPlatzer commented 7 months ago

I have updated our files to use file-scoped namespaces. This reduces the indentation of basically all our code by one level, making the code easier to read and understand.

Obviously, this is a massive change in terms of affected lines (and GitHub's diffing algorithm doesn't make it easy to understand) but I think it's still worthwhile because it makes our code easier to understand. The only reason you wouldn't a file-scoped namespace is if you were going to have multiple namespaces in one file. Given that we only do this in ServiceInterface.cs, I think this is a worthwhile change.

I also ran the code cleanup configuration tool which applies our editor config formatting settings to the codebase. This seems to have mostly affected bad whitespace (i.e. missing commas) as well as alphabetizing using statements.