gordon-cs / gordon-360-api

The 360° Gordon Experience
11 stars 6 forks source link

S24 mailbox information #1056

Closed jsenning closed 2 months ago

jsenning commented 2 months ago

Every time a student profile is loaded by the UI, the API is asked for the student's mailbox combination. This request is impossible to fulfill if the student does not have a mailbox number. While probably not an issue for actual students, it does mean that when we authenticate using our test student account (360.StudentTest) the API always halts with a thrown exception. We can safely ignore this exception as the API will merely return the mailbox information with an empty combination string.

While making that fix, it seemed reasonable to change the API route name and several function names to more accurately reflect the fact that the request is for mailbox information (which includes the combination, if it exists) rather than only the mailbox combination.

See PR 2334 in gordon-360-ui