Open russtuck opened 2 months ago
Notes from conversation w/ J Senning, so I don't forget:
I think this is a pure refactor. It should not change any behavior, but extracts permission code for easier reuse.
With only casual testing, it appears to be working. Please take a look.
I was only able to check the schedule security fix for viewing students and faculty as student and faculty.
It needs testing for viewing alumni from both kinds of accounts.
This is just a first draft, but I'd appreciate feedback if you have time to look. I know I still need to add code to check KeepPrivate, in order to honor FERPA restrictions on looking up student information.
One obvious question is whether ImposePrivacySettings() will make it unnecessary to distinguish copying the full profile vs. the public profile. I've made the optimistic but probably over-simplistic assumption that it might.