gordon-cs / gordon-360-ui

Gordon 360 User Interface
https://360.gordon.edu
16 stars 10 forks source link

Hl student UI update #2182

Closed JayBae9903 closed 4 months ago

JayBae9903 commented 7 months ago

Here's what I did:

  1. Set the instructions box to open by default
  2. Disable input for the first applicant field.
  3. Add validation for the preferred hall, and preferences (I tried to add the validation function for email, but I think it's more like a backend function, so I couldn't complete it. So, right now, the validation only checks if the email ends with @gordon.edu.)
  4. Add submit completion snack bar
  5. Minor changes
JayBae9903 commented 6 months ago

I added an email auto-complete function too. So, this branch has some minor improvements in the student UI.

ahwnsals1234 commented 6 months ago

As for the 3rd thing you did, that's exactly what I did couple months ago and we already have it implemented. if you weren't able to do full validation of the email, can you just remove the fixes you made for that function?

JayBae9903 commented 6 months ago

As for the 3rd thing you did, that's exactly what I did couple months ago and we already have it implemented. if you weren't able to do full validation of the email, can you just remove the fixes you made for that function?

The problem I found was when I tried to submit the application with invalid emails, I was able to submit it. So I think the email validation function is not working now.