add error screen for events

gordon-cs / gordon-360-ui

Gordon 360 User Interface

https://360.gordon.edu

15 stars 10 forks source link

add error screen for events #2255

Closed dli505 closed 2 weeks ago

dli505 commented 1 month ago

Changes made in PR:

when there is an error in retrieving events there should now be an error screen instead of an infinite spinner
Something like so:

amos-cha commented 1 month ago

@EjPlatzer I don't think there will ever be an error now with the API update to pass in an empty array right?

russtuck commented 4 weeks ago

It appears that recent backend changes hide the distinction between "unable to get event data" and "there are no matching events". It would be nice to make this clear to the user. Priority???

jsenning commented 2 weeks ago

The fix in this PR was made unnecessary due to changes in the API.