gordon-matt / peachpie-responsive-file-manager

Responsive File Manager running on .NET Core with Peachpie
24 stars 16 forks source link

removed unnecessary files, fixed `contentFiles`, updated PeachPie #11

Closed jakubmisek closed 4 years ago

jakubmisek commented 4 years ago
gordon-matt commented 4 years ago

Wow, that's a lot of changes. I am a little concerned about some of them though. For example, this one:

does not (should not) include .php files in NuGet

There is a good reason that I included those php files. I did not include all of the php files.. only the language files, because the Responsive File Manager was throwing errors when it could not find them.

Anyway, thanks. I will try to view and merge soon.

gordon-matt commented 4 years ago

Also.. all those file manager files that you deleted served a purpose as well.. While developing (example: testing a new version of RFM), then I will use the files instead of the NuGet package.. and then later when I confirmed it's working, then I will release the NuGet package and switch to that instead of the files. That's why I had both a <PackageReference> and a <ProjectReference> in the .csproj. I switch between NuGet package and normal files depending on if I am in development mode or release.

And the local NuGet feed is also useful for testing NuGet packages to make sure they work, before releasing it.

jakubmisek commented 4 years ago

thanks for reviewing; all these were considered.

gordon-matt commented 4 years ago

It's working well. Nicely done, thank you. New package is on NuGet now.

jakubmisek commented 4 years ago

great! thank you :)