Closed jakubmisek closed 4 years ago
Wow, that's a lot of changes. I am a little concerned about some of them though. For example, this one:
does not (should not) include .php files in NuGet
There is a good reason that I included those php files. I did not include all of the php files.. only the language files, because the Responsive File Manager was throwing errors when it could not find them.
Anyway, thanks. I will try to view and merge soon.
Also.. all those file manager files that you deleted served a purpose as well.. While developing (example: testing a new version of RFM), then I will use the files instead of the NuGet package.. and then later when I confirmed it's working, then I will release the NuGet package and switch to that instead of the files. That's why I had both a <PackageReference>
and a <ProjectReference>
in the .csproj. I switch between NuGet package and normal files depending on if I am in development mode or release.
And the local NuGet feed is also useful for testing NuGet packages to make sure they work, before releasing it.
thanks for reviewing; all these were considered.
It's working well. Nicely done, thank you. New package is on NuGet now.
great! thank you :)
updated to PeachPie 0.9.970
project structure fixes, copy and pack files properly
.php
files in NuGet/fiemanager
static files updated, copied from NuGet/Project properlyupdated readme
/filemanager
updated (it is now outside of wwwroot)removed local nuget feed (causes problems with building)