gordon-matt / peachpie-responsive-file-manager

Responsive File Manager running on .NET Core with Peachpie
24 stars 16 forks source link

upload error #17

Closed RenMen closed 2 years ago

RenMen commented 4 years ago

when try to upload file other than jpg,png,gif the below module throws null error exception @ / if (!empty($extensions)) /

protected function fix_file_extension($file_path, $name, $size, $type, $error, $index, $content_range) { // Add missing file extension for known image types: if (strpos($name, '.') === false && preg_match('/^image\/(gif|jpe?g|png)/', $type, $matches)) { $name .= '.'.$matches[1]; } if ($this->options['correct_image_extensions']) { switch ($this->imagetype($file_path)) { case self::IMAGETYPE_JPEG: $extensions = array('jpg', 'jpeg'); break; case self::IMAGETYPE_PNG: $extensions = array('png'); break; case self::IMAGETYPE_GIF: $extensions = array('gif'); break; } // Adjust incorrect image file extensions: if ( isset($extensions)) { //!empty is throwing null expception if try to upload jpg,png,gif $parts = explode('.', $name); $extIndex = count($parts) - 1; $ext = strtolower(@$parts[$extIndex]); if (!in_array($ext, $extensions)) { $parts[$extIndex] = $extensions[0]; $name = implode('.', $parts); } } } return $name; }`

jakubmisek commented 4 years ago

this has been fixed with the pull request https://github.com/gordon-matt/peachpie-responsive-file-manager/pull/16

gordon-matt commented 4 years ago

PR #16 is merged. But waiting on issue #18 to be resolved first before releasing new packages.