gordon-matt / peachpie-responsive-file-manager

Responsive File Manager running on .NET Core with Peachpie
24 stars 16 forks source link

mb_lang not supported #18

Closed carry2web closed 3 years ago

carry2web commented 4 years ago

I got this testing responsive file manager with peach pie and switching language via the globe icon:

Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request starting HTTP/2.0 POST https://localhost:44317/filemanager/ajax_calls.php?action=get_lang 0 PHP (Warning): Function 'mb_language' is not supported Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 125.1492ms 200 text/html; charset=UTF-8 Exception thrown: 'Pchp.Core.ScriptDiedException' in ResponsiveFileManager.dll An exception of type 'Pchp.Core.ScriptDiedException' occurred in ResponsiveFileManager.dll but was not handled in user code

Is this caused by peachpie not having mb_language implemented or am I missing something locally?

jakubmisek commented 4 years ago

mb_language shows the warning, but it has no effect on the application. (It only affects sending emails, which is not even needed for responsive file manager. I'm not sure why the author of responsive file manager put it there.)

ScriptDiedException (https://docs.peachpie.io/api/ref/scriptdiedexception/) is usually a handled by-design exception. Does it crash the application, or is it just handled by Visual Studio debugger and the application continues?

jakubmisek commented 4 years ago

Seems the exit() in source code (causing ScriptDieException) can be ignored.

Anyways there was no list of languages when clicking on globe icon; it is caused by peachpie (https://github.com/peachpiecompiler/peachpie/issues/850), will be fixed in the next update

jakubmisek commented 4 years ago

with the issue fixed, the languges are listed as below

image

thanks for reporting the issue!

gordon-matt commented 4 years ago

Thanks @jakubmisek . I have just merged PR #16 . I won't release it yet though.. I think its best to wait for you to either raise another PR with the new PeachPie referenced or update me here when its available and I will do so myself. Then I will release the new NuGet packages.

jakubmisek commented 4 years ago

@gordon-matt thanks, the next update will be in a few days