search

gordonbanderson / Mappable

Mappable module for SilverStripe CMS
BSD 3-Clause "New" or "Revised" License
10 stars 2 forks source link

Fixes for 3.1 #1

Closed wernerkrauss closed 10 years ago

wernerkrauss commented 11 years ago

Fixed config and some vars (width, height) that have not been passed to the map correctly.

Commented out the error_log.

hth,

Werner

gordonbanderson commented 11 years ago

hi Werner

From my limited knowledge of German (I studied it for a single year 25 years ago) I hope I've got your name right from your username. If not, apologies.

I need to get some client work out of the way but I will test your changes on my local copy in the next 2 to 3 days. Can I ask exactly which 3.1 version you are using, my demo app on http://demo.weboftalent.asia/mappable/ is using 3.1 beta 2. A quick scan of the diffs looks ok, but midnight my time, not the best time to merge a pull request :)

Thanks for your fixes, and good to know someone is using my code

Regards

Gordon

wernerkrauss commented 11 years ago

Hi Gordon,

yes you got my right firstname ;)

First thanks for updating mappable to 3.x and google maps v3. Saved a lot of work.

ATM i develop on the git branch, my current version of 3.1 is https://github.com/silverstripe/silverstripe-framework/commit/daa0b3cb790378557ef3333d816b06ff2b874265 from a week ago.

So it's pretty up to date, at least with the private static stuff.

Glad you like my contribution.

Have a nice day,

Werner