This module is quite old and was adapted from the original Uncle Cheese version from 2.4 - I'm not surprised that there are PSR2 issues with it, so thanks for the PR. I assume you used phpcbf, I have an alias alias fixpsr2='~/.composer/vendor/bin/phpcbf -p ', and then do fixpsr2 /path/to/src. Mmmm, interesting to note the tests have had a PSR2 sweep.
I'm only coding part time at the moment as I'm dealing with affairs post a bereavement, as such can you confirm the module still works after the change (I've never seen issues with automated PSR2 fixing tools). If so, I'll merge the PR and bump the version number in packagist.
I'm in the process of updating this to SS4, I note now that the map key is now mandatory, has this caused any issues?
hi,
This module is quite old and was adapted from the original Uncle Cheese version from 2.4 - I'm not surprised that there are PSR2 issues with it, so thanks for the PR. I assume you used phpcbf, I have an alias
alias fixpsr2='~/.composer/vendor/bin/phpcbf -p ', and then dofixpsr2 /path/to/src. Mmmm, interesting to note the tests have had a PSR2 sweep.I'm only coding part time at the moment as I'm dealing with affairs post a bereavement, as such can you confirm the module still works after the change (I've never seen issues with automated PSR2 fixing tools). If so, I'll merge the PR and bump the version number in packagist.
I'm in the process of updating this to SS4, I note now that the map key is now mandatory, has this caused any issues?
Cheers
Gordon