gordonjb / graplist.fm

Stats for wrestling shows you've attended, sourced from Cagematch.net. setlist.fm, for wrestling. Taking suggestions for better names
2 stars 0 forks source link

Deal with partial shows #13

Closed gordonjb closed 4 years ago

gordonjb commented 5 years ago

I have shows that I only saw part of (had to leave early) and cards where I only actually saw some of the matches (due to tapings, e.g. April 2010 ## - https://www.cagematch.net/?id=1&nr=50185 # WWE Superstars #53 : only one match of this show! how TF is this going to work)

How can we deal with these? We could just use the non Cagematch shows mechanic from #12, but something more integrated would be nice to have.

N.B, this will also also need to work with #11, show merging

gordonjb commented 5 years ago

Could also add a partial flag to the database, give the option to include/exclude partial shows from certain stats?

gordonjb commented 5 years ago

Ok so:

[ ] Add exclude flag to database. I'll figure out how to set this later. [ ] Similar to squash, add a partial tag to the lists. Expect two items, the URL and a set of matches to be ignored like {1,2,4} [ ] Get a list of workers who are in these matches, and not included in any other matches, and check this list against ones we're trying to add

gordonjb commented 5 years ago

merged partial and exclude into one flag, as bools are ints anyway.

0 obviously means it's not partial. 1 means it's a partial show 2 means it's a partial show and should be excluded

this means that is_partial > 0 will always return true when it should

gordonjb commented 4 years ago

Need to come up with some tests to verify that filtering is working correctly, include some edge cases

gordonjb commented 4 years ago

For exclude filter: check each match to try identify worker ids as we do for all workers, try use this in first instance to include/exclude, then fall back to relying on text, as this does have failing cases.