search

gordonklaus / ineffassign

Detect ineffectual assignments in Go code.
MIT License
390 stars 22 forks source link

Make it easier to use this analyzer as a library. #56

Closed rmohr closed 3 years ago

rmohr commented 3 years ago

Having a separate directory allows using the analyzer logic without having to import golang.org/x/tools/go/analysis/singlechecker, which causes cyclic dependency issues with nogo on bazel.

The PR mainly moves the "library" part into a pkg/ineffassign subfolder.

rmohr commented 3 years ago

@gordonklaus it would be great if this or something like this change could be considered. The change allows me to easily integrate this into nogo in kubeveirt.

gordonklaus commented 3 years ago

@rmohr Looks good, but can you change the second commit message to start with the text BREAKING CHANGE and to contain the new instructions for how to install the tool (just as you did in the README). Just to make it a little easier for those folks who are going to trip over this.

rmohr commented 3 years ago

@rmohr Looks good, but can you change the second commit message to start with the text BREAKING CHANGE and to contain the new instructions for how to install the tool (just as you did in the README). Just to make it a little easier for those folks who are going to trip over this.

@gordonklaus thanks for the review. Was out a few days. Considering your BREAKING CHANGE remark I changed the angle of the PR, to move the library code into pkg/ineffassign. That is sufficient for my needs and avoids any breaking changes. Works gresat for me in https://github.com/kubevirt/kubevirt/pull/4909.

Happy if you take another look.