false positive: warning: ineffectual assignment to tm

[Setheck]

Kind of interesting because it was reported by https://goreportcard.com/report/github.com/Setheck/dat and reported twice

code is

    var (
        tm     time.Time
        format string
    )
    if opts.Tf {
        tm, format, err = ParseTime(epochstr)
        if err != nil {
            return err
        }
        if name, ok := supportedTimeFormats[format]; ok {
            fmt.Println("detected format:", name)
        } else {
            fmt.Println("failed to detect format.")
        }
        return nil
    } else {
        // validate and convert to time
        tm, err = ParseEpochTime(epochstr, opts.Milliseconds)
        if err != nil {
            return err
        }
    }

    output := buildOutput(tm, opts)
    if opts.Copy {
        if err := clipper.ClipboardHelper.WriteAll(strings.TrimSpace(output)); err != nil {
            return err
        }
    }

[gordonklaus]

A false positive means the assignment is in fact effectual. So, I ask you: where is the value assigned to tm used? (Maybe you overlooked the unconditional return nil?)

[Setheck]

It's passed into buildOutput E: oooh ok this is my mistake. I realize that it's the inner scoped tm. I should have gone to bed earlier 😅