search

gordonklaus / ineffassign

Detect ineffectual assignments in Go code.
MIT License
390 stars 22 forks source link

Bump golang.org/x/tools to v0.7.0 (as minimum) and make new tag #79

Closed Antonboom closed 1 year ago

Antonboom commented 1 year ago

Hi 🙂

Please, bump golang.org/x/tools to v0.7.0 (as minimum) and make new tag in your repo.

It's important to be consistent with new Go 1.20 golangci-lint. Related to https://github.com/golangci/golangci-lint/issues/3086

Thanks!

P.S. Optionally I recommend

Antonboom commented 1 year ago

UPD:

Sorry, false-positive, don't see usage of buildssa.Analyzer. But pay attention anyway :)

gordonklaus commented 1 year ago

Hi @Antonboom :)

What should I pay attention to? Since it's a false positive then this issue can be closed?

Antonboom commented 1 year ago

What should I pay attention to

A standalone SSA-based linter may break on new Golang code if too old x/tools/ssa is used.

this issue can be closed

Yep, right

Thanks