gordontucker / FittedSheets

Bottom sheets for iOS
MIT License
1.35k stars 278 forks source link

Add ability to disable ending editing on resize #228

Open stevelandeyasana opened 5 months ago

stevelandeyasana commented 5 months ago

I'm working on a comment editor which presents as a persistent bottom sheet. I was finding that when I drag between detents, my text field was being forced to resign its responder, which is bad. There was also a visual bug where the sheet would be the wrong height during the drag due to its offsets being computed with the keyboard up.

Rather than removing the behavior for all users, I added a config option, but I'm not convinced it's better than simply removing the call to endEditing(). It would be better to have some kind of configurable callback so users can choose to end editing if it makes sense for their use case. What do you think?

This line was added a very long time ago, maybe you have some context you can share @gordontucker?