AST Manipulation - asts should be immutable

gordonwatts / BDTTrainingAnalysisLanguage

Pull from ATLAS EXOT 15 Derivation, columnar data, and flat rootutples with RDF to scikitlearn in one nice fast swoop

0 stars 2 forks source link

AST Manipulation - asts should be immutable #70

Open gordonwatts opened 5 years ago

gordonwatts commented 5 years ago

We need to keep asts immutable. In some of the transformers - like function_simplifier we needed a deepcopy. That is a sure sign we are doing something we shouldn't be.

Before doing this, look at how Python does the TransformNodeVIsitor. If it doesn't make a new tree as it goes, then this bug report really doesn't matter.