problem statement review

gordonwky / GMM_EM

Other

0 stars 0 forks source link

problem statement review #1

Closed gordonwky closed 9 months ago

smiths commented 9 months ago

@gordonwky, please provide a link to your problem statement in the issue to facilitate the review. :smile:

gordonwky commented 9 months ago

https://github.com/gordonwky/GMM_EM/tree/main/docs/ProblemStatementAndGoals

gordonwky commented 9 months ago

The repo contains the pdf and tex file https://github.com/gordonwky/GMM_EM/tree/main/docs/ProblemStatementAndGoals

Spencer Smith @.***> 於 2024年1月19日週五下午6:34寫道：

@gordonwky https://github.com/gordonwky, please provide a link to your problem statement in the issue to facilitate the review. 😄

— Reply to this email directly, view it on GitHub https://github.com/gordonwky/GMM_EM/issues/1#issuecomment-1901294346, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUVDMWJBTDQL7NSLPKVXFZ3YPL7HFAVCNFSM6AAAAABCCVUJ2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBRGI4TIMZUGY . You are receiving this because you were mentioned.Message ID: @.***>

gordonwky commented 9 months ago

https://github.com/gordonwky/GMM_EM/blob/main/docs/ProblemStatementAndGoals/cas741_problem_statement.pdf

This is the pdf

smiths commented 9 months ago

Feedback:

you can use markdown to make nice links, instead of writing out the entire url
you need to think whether your project will be a library, or a program. The only difference is that in the program version you have a user-facing interface
it would be nice to see some equations in the problem statement :smile:
not using external libraries is probably not feasible, or even desirable. Your obligation for testing goes up much higher if you are writing all of your own code

The project sounds interesting. I'm looking forward to it. We'll need to keep an eye on the scope to make sure it isn't too much work.

Your project is approved.