fix: Run golangci-lint only with default linters - Githubissues

goreleaser / godownloader

[DEPRECATED] Download Go binaries as fast and easily as possible.

MIT License

445 stars 54 forks source link

fix: Run golangci-lint only with default linters #167

Closed haya14busa closed 4 years ago

haya14busa commented 4 years ago

golangci-lint add more and more linters, so new/updated linter can fail with existing code (e.g. [1]). It's also very slow to run all linters on pre-commit too, IMO.

We could add golangci-lint config too, but I prefer running default linters for now, as it's currently failing and reason described above.

[1] https://travis-ci.org/goreleaser/godownloader/builds/632690812?utm_source=github_status&utm_medium=notification main.go:285:12: mnd: Magic number: 1, in detected (gomnd) os.Exit(1) ^

github-actions[bot] commented 4 years ago

This pull-request seems be stale, will auto-close soon.