search

goreleaser / goreleaser-action

GitHub Action for GoReleaser
https://github.com/marketplace/actions/goreleaser-action
MIT License
865 stars 78 forks source link

goreleaser-action tries to download incorrect version of installer on armv6 #308

Closed tenyo closed 3 years ago

tenyo commented 3 years ago

Hi, I'm trying to run gorelease-action on a 32-bit ARM machine (armv6 arch) and it's trying to download goreleaser_Linux_arm.tar.gz which doesn't exist.

Downloading https://github.com/goreleaser/goreleaser/releases/download/v0.180.3/goreleaser_Linux_arm.tar.gz
Error: Unexpected HTTP response: 404

The correct goreleaser binary in this case should be called goreleaser_Linux_armv6.tar.gz from looking at https://github.com/goreleaser/goreleaser/releases

tenyo commented 3 years ago

Guessing that the problem is again in https://github.com/goreleaser/goreleaser-action/blob/master/src/installer.ts#L50

crazy-max commented 3 years ago

Yes we don't handle arch variant atm.

crazy-max commented 3 years ago

@tenyo Can you try with uses: goreleaser/goreleaser-action@master?

tenyo commented 3 years ago

@crazy-max Thanks for the quick fix! It kinda worked but still failing in my case. I see it's correctly identifying the arch (armv7) but that version of goreleaser doesn't exist, there's only armv6. So, I guess, the question is, will the goreleaser_Linux_armv6 binary work on armv7 (I would think so), in which case we can always download the armv6 version?

> Run goreleaser/goreleaser-action@master
Downloading https://github.com/goreleaser/goreleaser/releases/download/v0.180.3/goreleaser_Linux_armv7.tar.gz
Error: Unexpected HTTP response: 404
crazy-max commented 3 years ago

I guess GoReleaser should produce v7 variant binaries instead. cc @caarlos0

caarlos0 commented 3 years ago

Yeah, just need to add to the config

tenyo commented 3 years ago

Thanks a lot guys! It downloads the correct version now after the last release which includes the v7 binary 🎉