goreleaser / goreleaser-action

GitHub Action for GoReleaser
https://github.com/marketplace/actions/goreleaser-action
MIT License
833 stars 73 forks source link

chore: node 20 as default runtime #432

Closed crazy-max closed 9 months ago

crazy-max commented 9 months ago

Node 16 reaches the end of life on Sep, 11 2023. Node 20 is supported on GitHub Runners since https://github.com/actions/runner/releases/tag/v2.308.0.

codecov[bot] commented 9 months ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5fdedb9). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #432   +/-   ##
=========================================
  Coverage          ?   66.92%           
=========================================
  Files             ?        3           
  Lines             ?      130           
  Branches          ?       23           
=========================================
  Hits              ?       87           
  Misses            ?       27           
  Partials          ?       16           
crazy-max commented 9 months ago

@caarlos0 Looks like we have an issue with nightly releases: https://github.com/goreleaser/goreleaser-action/actions/runs/6132162449/job/16642788626?pr=432#step:4:8

image

Seems to happen for a couple of days:

image

dirien commented 9 months ago

This PR is confusing, as you update yarn and the runtime to node20. Is this linked to each other?

crazy-max commented 9 months ago

This PR is confusing, as you update yarn and the runtime to node20. Is this linked to each other?

There are separate commits in my history so it's easy to relate each change but merge policy of goreleaser enforces squash :man_shrugging::

image

And no, yarn update not necessary. I just took the opportunity to do it as I needed to update dev deps.