goreleaser / goreleaser-cross

Docker image for Golang cross-compiling with CGO
MIT License
146 stars 24 forks source link

feat: support goreleaser-pro #23

Closed caarlos0 closed 1 year ago

caarlos0 commented 1 year ago

very WIP

@troian I'm not sure what's the best way here... some options:

  1. we build multiple images, like the regular goreleaser/goreleaser-pro images
  2. we install both in the same image and handle it in the entrypoint... that will need some tricks because both packages install the goreleaser binary
  3. in both cases, I think we could copy the binary from the goreleaser images instead of installing the deb, which would likely simplify things
  4. in both cases, I think we'll need to move the actualy goreleaser install to the leaf image instead of the base

thoughs?

refs #22

troian commented 1 year ago

i think 1 would be the best option. and totally agree on 4.

i'll rearrange image steps and base images and we'll move from that

caarlos0 commented 1 year ago

ah sounds good @troian thanks

troian commented 1 year ago

alrighty, i did some play with that and now master has pro integrated.

caarlos0 commented 1 year ago

awesome, thank you so much @troian