goreleaser / goreleaser-cross

Docker image for Golang cross-compiling with CGO
MIT License
156 stars 26 forks source link

v1.22.5 image tag is missing #79

Closed rootulp closed 2 months ago

rootulp commented 3 months ago

Context

The v1.22.5 image tag is missing from https://github.com/goreleaser/goreleaser-cross/pkgs/container/goreleaser-cross/versions?filters%5Bversion_type%5D=tagged

Problem

Our repo upgrades Golang versions regularly and it is a maintenance burden to check if the relevant goreleaser-cross image version exists.

Proposal

Create a goreleaser-cross image tag for every Go release.

troian commented 3 months ago

i'll release it in a next day or two, have to do it manually as gh actions runners always fails due to no space issue. you can use v1.22.6 tho

rootulp commented 3 months ago

Thanks yea we worked around the issue by bumping to Go 1.22.6 in https://github.com/celestiaorg/celestia-app/pull/3803 but we can't get pre-built binaries attached to the original release because we can't modify CI on that release. I cut a subsequent release and hit a different goreleaser problem here 🤦‍♂️

rootulp commented 3 months ago

We stopped using a deprecated field in https://github.com/celestiaorg/celestia-app/pull/3795 but it looks like goreleaser-cross just bumped to goreleaser v2.2.0 in https://github.com/goreleaser/goreleaser-cross/commit/239cf409a6514c83ab7c682906385c2662c87baa so we need to bump to that

qwqcode commented 2 months ago

golang 1.22.7 has also been released, which fixes security issues

troian commented 2 months ago

1.22.7 released

caarlos0 commented 2 months ago

fwiw this replaced :latest as well it seems

caarlos0 commented 2 months ago

running this to fix:

  for name in goreleaser-cross-base goreleaser-cross goreleaser-cross-pro
          for registry in ghcr.io docker.io
                  docker pull $registry/goreleaser/$name:v1.23.1
                  docker tag $registry/goreleaser/$name:v1.23.1 $registry/goreleaser/$name:latest
                  docker push $registry/goreleaser/$name:latest
              end
  end