search

goreleaser / nfpm

nFPM is Not FPM - a simple deb, rpm, apk, ipk, and arch linux packager written in Go
https://nfpm.goreleaser.com/
MIT License
2.17k stars 157 forks source link

Feature/deb package changes #612

Open ArtemTrofimushkin opened 1 year ago

ArtemTrofimushkin commented 1 year ago

Fixes https://github.com/goreleaser/nfpm/issues/488

erikgeiser commented 1 year ago

Thanks for the PR. I didn't have time to read it completely, yet, but I took a glance at the changes. Maybe Distribution and Urgency should be required to set. I'm not sure that setting them automatically to unstable and medium makes sense as we don't even know what is being packaged and for which distro. If people want the metadata these values should probably be deliberate.

ArtemTrofimushkin commented 1 year ago

@erikgeiser Thanks for the explanation. Updated the PR to make these fields required (removed default values in SetPackagerDefaults)

caarlos0 commented 4 months ago

hey! sorry for the delay reviewing this...

lets merge it with main and get it in for v2.39?

ArtemTrofimushkin commented 2 months ago

Hello @caarlos0 ! I'm very sorry for loong delay, let's try to merge changes?

caarlos0 commented 2 months ago

hey, seems like there are some tests failing, can you take a look?

ArtemTrofimushkin commented 1 month ago

@caarlos0 all fixed. Locally all tests passed. Can you run all checks again?

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 65.82278% with 27 lines in your changes missing coverage. Please review.

Project coverage is 72.91%. Comparing base (db338d0) to head (708cb47). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/package.go 0.00% 17 Missing :warning:
deb/deb_meta.go 82.75% 5 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #612 +/- ## ========================================== - Coverage 73.16% 72.91% -0.25% ========================================== Files 22 23 +1 Lines 2493 2570 +77 ========================================== + Hits 1824 1874 +50 - Misses 463 485 +22 - Partials 206 211 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.